Add support for rate-limiting throughput #24
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 177 213 +36
Branches 34 38 +4
=========================================
+ Hits 177 213 +36 ☔ View full report in Codecov by Sentry. |
|
Thank you! I'll do the careful review a little later, it takes time. |
|
@asvetlov Hello, just reminding you of this PR and project 😇 . Hope you are doing well and will be able to take a look at this. |
|
@asvetlov Hello again, do you think you'll be able to review this PR 🙂? I understand if life keeps getting in the way, it happens to me all the time as well. I just think it would be unfortunate to abandon this 🥺 . |
pyproject.toml
Outdated
| authors = [ | ||
| {name = "Andrew Svetlov",email = "[email protected]"} | ||
| {name = "Andrew Svetlov",email = "[email protected]"}, | ||
| {name = "Martin Jurča", email = "[email protected]"} |
There was a problem hiding this comment.
This core packaging metadata isn't supposed to reflect everybody who ever committed to the repository. It's more about substantial contributions, like a global rewrite or similar. Does this patch qualify?
There was a problem hiding this comment.
While I was the initiator of the effort that resulted in this library, this patch most likely does not quality, so I dropped the commit that updated the authors.
I'll still be happy to help with maintaining this library 🙂.
The test is now less sensitive to the computational performance of the runner's environment.
4 participants
What do these changes do?
Adds the optional
max_throughputconstructor parameter, which enables rate-limiting task processing using a sliding time window (currently set to 1 second).Are there changes in behavior for the user?
New feature.
Related issue number
Relates to #13
Checklist